Skip to content

fix: typos in documentation files#5114

Merged
mcmire merged 10 commits intoMetaMask:mainfrom
vtjl10:main
Mar 5, 2025
Merged

fix: typos in documentation files#5114
mcmire merged 10 commits intoMetaMask:mainfrom
vtjl10:main

Conversation

@vtjl10
Copy link
Contributor

@vtjl10 vtjl10 commented Jan 8, 2025

This pull request contains changes to improve clarity, correctness and structure.

Description correction:
Corrected exection to execution
Corrected hexidecimal to hexadecimal x2
Corrected emtpy to empty

Please review the changes and let me know if any additional changes are needed.

@vtjl10 vtjl10 requested review from a team as code owners January 8, 2025 11:32
Gudahtt
Gudahtt previously approved these changes Jan 8, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@mcmire
Copy link
Contributor

mcmire commented Jan 8, 2025

@vtjl10 It looks like this causes some tests to fail in the tests for NameController, would you be willing to fix those cases too?

@Gudahtt Gudahtt dismissed their stale review January 8, 2025 20:50

Test failures

@vtjl10 vtjl10 requested a review from Gudahtt January 22, 2025 22:35
@mcmire mcmire enabled auto-merge (squash) January 31, 2025 21:00
@mcmire mcmire disabled auto-merge January 31, 2025 21:00
@mcmire
Copy link
Contributor

mcmire commented Jan 31, 2025

@vtjl10 I fixed the test on this PR. We are just awaiting approval from @MetaMask/confirmations .

@vtjl10
Copy link
Contributor Author

vtjl10 commented Mar 5, 2025

@Gudahtt @mcmire ready to merge?

@mcmire mcmire enabled auto-merge (squash) March 5, 2025 16:02
@mcmire
Copy link
Contributor

mcmire commented Mar 5, 2025

@vtjl10 I have notified our Confirmations team to review and approve this.

@mcmire mcmire merged commit d9b0353 into MetaMask:main Mar 5, 2025
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants